Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Pass BSDmakefile args to gmake #1298

Closed
wants to merge 1 commit into from

Conversation

jbergstroem
Copy link
Member

Minor convenience for platforms that doesn't have gmake installed but prefer the habit of writing make instead of gmake.

test needs to live in .PHONY to get passed on to gmake.

/R=@indutny?

Minor convenience for platforms that doesn't have gmake installed
but prefer the habit of writing make instead of gmake.

test needs to live in .PHONY to get passed on to gmake.
@mscdex mscdex added the build Issues and PRs related to build files or the CI. label Mar 31, 2015
@indutny
Copy link
Member

indutny commented Mar 31, 2015

Hm... I guess it'll simplify the build process a lot :) LGTM, if it works.

@indutny
Copy link
Member

indutny commented Mar 31, 2015

Thank you!

@jbergstroem
Copy link
Member Author

"lgtm if it works" 😀

jbergstroem added a commit that referenced this pull request Apr 1, 2015
Minor convenience for platforms that doesn't have gmake installed
but prefer the habit of writing make instead of gmake.

test needs to live in .PHONY to get passed on to gmake.

PR-URL: #1298
Reviewed-By: Fedor Indutny <[email protected]>
@jbergstroem
Copy link
Member Author

Merged in 5094a0f. Thanks for the review.

Fyi - tested on FreeBSD. make on OpenBSD doesn't default to BSDMakefile. If I recall correctly, it's only descendants of pmake that does so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants